Skip to content

Implement prefetch KASLR leak#152

Merged
GJL merged 2 commits intogoogle:mainfrom
GJL:prefetch-leak
Mar 25, 2026
Merged

Implement prefetch KASLR leak#152
GJL merged 2 commits intogoogle:mainfrom
GJL:prefetch-leak

Conversation

@GJL
Copy link
Copy Markdown
Collaborator

@GJL GJL commented Nov 27, 2025

No description provided.

Copy link
Copy Markdown
Collaborator

@koczkatamas koczkatamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I had one question / change suggesion.

Comment thread libxdk/util/pwn_utils.cpp Outdated
@GJL GJL force-pushed the prefetch-leak branch from 9d7d306 to 54695c5 Compare March 4, 2026 05:18
@GJL GJL marked this pull request as draft March 4, 2026 05:19
@GJL GJL force-pushed the prefetch-leak branch from 54695c5 to 4513bd4 Compare March 4, 2026 05:20
@GJL GJL force-pushed the prefetch-leak branch 3 times, most recently from f608b5b to 01f0cca Compare March 18, 2026 05:26
@GJL GJL marked this pull request as ready for review March 18, 2026 05:27
@GJL GJL force-pushed the prefetch-leak branch 5 times, most recently from f205c1e to ed03484 Compare March 18, 2026 07:40
Copy link
Copy Markdown
Collaborator

@koczkatamas koczkatamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few comments, nothing serious, few suggestions and questions.

Comment thread libxdk/util/pwn_utils.cpp
Comment thread libxdk/include/xdk/util/pwn_utils.h
Comment thread libxdk/test/tests/UtilsRuntimeTests.h
Comment thread libxdk/test/tests/UtilsRuntimeTests.h
Comment thread libxdk/util/pwn_utils.cpp
Comment thread libxdk/util/pwn_utils.cpp
Copy link
Copy Markdown
Collaborator

@koczkatamas koczkatamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Still commented on the edge finding algo, but it's more about I am not understanding some aspect, it does not block merging.

@GJL GJL merged commit 62adf03 into google:main Mar 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants